fix(eslint-plugin): [explicit-module-boundary-types] don't check returned functions if parent function has return type #2084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @ifiokjr! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #2084 +/- ##
=======================================
Coverage 93.42% 93.42%
=======================================
Files 171 171
Lines 7755 7774 +19
Branches 2215 2222 +7
=======================================
+ Hits 7245 7263 +18
Misses 244 244
- Partials 266 267 +1
|
bradzacher
reviewed
May 25, 2020
packages/eslint-plugin/src/rules/explicit-module-boundary-types.ts
Outdated
Show resolved
Hide resolved
bradzacher
requested changes
May 25, 2020
f06e1e0 to
5cac715
Compare
ce93945 to
9b37ff0
Compare
|
I've just pushed again to:
|
Was complaining about inner function expressions. Fixes typescript-eslint#1845
Exit early when the type of the ancestor of the node being checked is not a return statement.
Ignore final return code path
cdffccb to
9f8d026
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Version 3.0.0 of the plugin enabled
explicit-module-boundary-typesby default. Unfortunately it doesn't currently handle the case where the parent function has a type signature. The following correct code produces an error.This fixes the problem by checking the parent nodes of exported declarations to see if they are already typed. If they are typed it doesn't show the error for child functions.
Fixes #1845