Skip to content

docs: broken markdown link in Contributing Guide in main README #2097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2020

Conversation

dimitropoulos
Copy link
Contributor

@dimitropoulos dimitropoulos commented May 25, 2020

presently, on https://github.com/typescript-eslint/typescript-eslint#contributing-guide if you click Contributing Guide in the table of contents at the top, it's broken because in 2b16019#diff-04c6e90faac2675aa89e2176d2eec7d8L300 it was changed from Contributing Guide to Contributing without the TOC link being updated.

Corrected demo (from this PR) here https://github.com/typescript-eslint/typescript-eslint/blob/309a423e41b0c1f72d00c48f6d33f27a8940e04b/README.md#contributing-guide

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @dimitropoulos!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@dimitropoulos dimitropoulos changed the title fixes broken markdown link in Contributing Guide in main README typo: fixes broken markdown link in Contributing Guide in main README May 25, 2020
@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #2097 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2097   +/-   ##
=======================================
  Coverage   93.44%   93.44%           
=======================================
  Files         171      171           
  Lines        7753     7753           
  Branches     2214     2214           
=======================================
  Hits         7245     7245           
  Misses        243      243           
  Partials      265      265           
Flag Coverage Δ
#unittest 93.44% <ø> (ø)

@dimitropoulos dimitropoulos changed the title typo: fixes broken markdown link in Contributing Guide in main README fix: broken markdown link in Contributing Guide in main README May 25, 2020
@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label May 25, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher changed the title fix: broken markdown link in Contributing Guide in main README docs: broken markdown link in Contributing Guide in main README May 25, 2020
@bradzacher bradzacher merged commit 7bc0706 into typescript-eslint:master May 25, 2020
@dimitropoulos dimitropoulos deleted the broken-md-link branch May 25, 2020 19:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants