fix: regression for eslint v6 #2105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2100 Includes an integration test against eslint v6 to ensure this doesn't happen again. Also spent a moment cleaning up the integration tests.
|
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #2105 +/- ##
==========================================
- Coverage 93.44% 93.42% -0.03%
==========================================
Files 171 171
Lines 7753 7755 +2
Branches 2214 2215 +1
==========================================
Hits 7245 7245
- Misses 243 244 +1
- Partials 265 266 +1
|
waitingsong
added a commit
to waitingsong/midway
that referenced
this pull request
May 27, 2020
- eslint - @typescript-eslint/eslint-plugin - @typescript-eslint/parser lerna.json hoist not need @typescript-eslint/* ref: typescript-eslint/typescript-eslint#2105
waitingsong
added a commit
to waitingsong/midway
that referenced
this pull request
May 27, 2020
- eslint - @typescript-eslint/eslint-plugin - @typescript-eslint/parser lerna.json hoist not need @typescript-eslint/* ref: typescript-eslint/typescript-eslint#2105
waitingsong
added a commit
to waitingsong/midway
that referenced
this pull request
May 27, 2020
- eslint - @typescript-eslint/eslint-plugin - @typescript-eslint/parser lerna.json hoist not need @typescript-eslint/* ref: typescript-eslint/typescript-eslint#2105
4 tasks
czy88840616
pushed a commit
to midwayjs/midway
that referenced
this pull request
May 28, 2020
* chore(devDeps): upgrade for eslint - eslint - @typescript-eslint/eslint-plugin - @typescript-eslint/parser lerna.json hoist not need @typescript-eslint/* ref: typescript-eslint/typescript-eslint#2105 * chore(eslint-midway-contrib): remove devDeps typescript
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2100
Includes an integration test against eslint v6 to ensure this doesn't happen again.
Also spent a moment cleaning up the integration tests.