Skip to content

docs(eslint-plugin): remove no-void from roadmap #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ianbollinger
Copy link
Contributor

The migration guide suggested migrating from TSLint's no-void-expression rule to ESLint's no-void rule despite the rules being unrelated (while having confusingly similar names.) This removes the link to no-void and fixes #1871.

…t#1871)

The migration guide suggested migrating from TSLint's
`no-void-expression` rule to ESLint's `no-void` rule despite the rules
being unrelated (while having confusingly similar names.) This removes
the link to `no-void` and fixes typescript-eslint#1871.
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @ianbollinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #2124 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2124   +/-   ##
=======================================
  Coverage   93.42%   93.42%           
=======================================
  Files         171      171           
  Lines        7755     7755           
  Branches     2215     2215           
=======================================
  Hits         7245     7245           
  Misses        244      244           
  Partials      266      266           
Flag Coverage Δ
#unittest 93.42% <ø> (ø)

@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label May 29, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bradzacher bradzacher changed the title docs(eslint-plugin): remove no-void from road map (#1871) docs(eslint-plugin): remove no-void from roadmap May 29, 2020
@bradzacher bradzacher merged commit 407bfa1 into typescript-eslint:master May 29, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-void-expression] Invalid entry on ROADMAP
2 participants