Skip to content

test(ts-estree): add missing test cases for parser options #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Feb 5, 2019

This PR adds missing test cases for converter and parse in ts-estree

@codecov
Copy link

codecov bot commented Feb 5, 2019

Codecov Report

Merging #213 into master will increase coverage by 0.2%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #213     +/-   ##
=========================================
+ Coverage   96.37%   96.57%   +0.2%     
=========================================
  Files          51       51             
  Lines        2455     2455             
  Branches      370      370             
=========================================
+ Hits         2366     2371      +5     
+ Misses         46       42      -4     
+ Partials       43       42      -1
Impacted Files Coverage Δ
packages/typescript-estree/src/parser.ts 92.98% <100%> (+1.75%) ⬆️
packages/typescript-estree/src/convert.ts 97.27% <0%> (+0.45%) ⬆️

@armano2 armano2 self-assigned this Feb 5, 2019
@armano2 armano2 requested a review from JamesHenry February 5, 2019 23:42
@armano2 armano2 changed the title test(parser): add missing test cases for parser options test(ts-estree): add missing test cases for parser options Feb 5, 2019
@armano2 armano2 added the package: typescript-estree Issues related to @typescript-eslint/typescript-estree label Feb 6, 2019
@JamesHenry JamesHenry merged commit fdac435 into typescript-eslint:master Feb 6, 2019
@armano2 armano2 deleted the tests branch February 6, 2019 01:54
kaicataldo pushed a commit to kaicataldo/typescript-eslint that referenced this pull request Aug 27, 2019
…pescript-eslint#227)

- correct url in no-misused-new
- add tslint addontation to no-namespace
- enable rules: eslint-plugin/no-deprecated-context-methods, eslint-plugin/prefer-output-null

fixes: typescript-eslint#213
fixes: typescript-eslint#212
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: typescript-estree Issues related to @typescript-eslint/typescript-estree
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants