Skip to content

test(ts-estree): upgrade babel to 7.3.2 #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2019
Merged

test(ts-estree): upgrade babel to 7.3.2 #217

merged 1 commit into from
Feb 6, 2019

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Feb 6, 2019

babel 7.3.2 got released yesterday, and this pr upgrades changes in alignment tests.

babel reports now error on invalid usage of identifiers/keywords in strict mode,
typescript has TS1100: "Invalid use of '{0}' in strict mode.", but i'm unsure if we want to error on this code.

@armano2 armano2 requested a review from JamesHenry February 6, 2019 01:05
@armano2 armano2 self-assigned this Feb 6, 2019
@armano2 armano2 added the package: typescript-estree Issues related to @typescript-eslint/typescript-estree label Feb 6, 2019
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's delay the decision on the diagnostic and just get this in

@JamesHenry JamesHenry merged commit 7777cae into typescript-eslint:master Feb 6, 2019
@armano2 armano2 deleted the error-code branch February 6, 2019 01:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: typescript-estree Issues related to @typescript-eslint/typescript-estree
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants