Skip to content

test(ts-estree): upgrade babel to 7.3.2 #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2019
Merged

test(ts-estree): upgrade babel to 7.3.2 #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
},
"devDependencies": {
"@babel/code-frame": "7.0.0",
"@babel/parser": "7.3.0",
"@babel/parser": "7.3.2",
"@commitlint/cli": "^7.1.2",
"@commitlint/config-conventional": "^7.1.2",
"@commitlint/travis-cli": "^7.1.2",
Expand Down
30 changes: 21 additions & 9 deletions packages/typescript-estree/tests/ast-alignment/fixtures-to-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,20 @@ tester.addFixturePatternConfig('javascript/arrowFunctions', {
* with the same name, for example.
*/
'error-dup-params', // babel parse errors
'error-strict-dup-params' // babel parse errors
'error-strict-dup-params', // babel parse errors
/**
* typescript reports TS1100 and babel errors on this
* TS1100: "Invalid use of '{0}' in strict mode."
* TODO: do we want TS1100 error code?
*/
'error-strict-eval', // babel parse errors
'error-strict-default-param-eval',
'error-strict-eval-return',
'error-strict-param-arguments',
'error-strict-param-eval',
'error-strict-param-names',
'error-strict-param-no-paren-arguments',
'error-strict-param-no-paren-eval'
]
});
tester.addFixturePatternConfig('javascript/function', {
Expand Down Expand Up @@ -236,7 +249,12 @@ tester.addFixturePatternConfig('javascript/modules', {
*/
'invalid-export-named-default' // babel parse errors
],
ignoreSourceType: ['error-function', 'error-strict', 'error-delete']
ignoreSourceType: [
'error-function',
'error-strict',
'error-delete',
'invalid-await'
]
});

tester.addFixturePatternConfig('javascript/newTarget');
Expand Down Expand Up @@ -363,15 +381,9 @@ tester.addFixturePatternConfig('typescript/basics', {
* https://github.com/babel/babel/issues/9324
*/
'type-assertion-arrow-function',
/**
* PR for range of declare keyword has been merged into Babel: https://github.com/babel/babel/pull/9406
* TODO: remove me in next babel > 7.3.1
*/
'export-declare-const-named-enum',
'export-declare-named-enum',
/**
* Babel does not include optional keyword into range parameter in arrow function
* TODO: report it to babel
* https://github.com/babel/babel/issues/9461
*/
'arrow-function-with-optional-parameter'
],
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@
esutils "^2.0.2"
js-tokens "^4.0.0"

"@babel/parser@7.3.0":
version "7.3.0"
resolved "https://registry.yarnpkg.com/@babel/parser/-/parser-7.3.0.tgz#930251fe6714df47ce540a919ccdf6dcfb652b61"
integrity sha512-8M30TzMpLHGmuthHZStm4F+az5wxyYeh8U+LWK7+b2qnlQ0anXBmOQ1I8DCMV1K981wPY3C3kWZ4SA1lR3Y3xQ==
"@babel/parser@7.3.2":
version "7.3.2"
resolved "https://registry.yarnpkg.com/@babel/parser/-/parser-7.3.2.tgz#95cdeddfc3992a6ca2a1315191c1679ca32c55cd"
integrity sha512-QzNUC2RO1gadg+fs21fi0Uu0OuGNzRKEmgCxoLNzbCdoprLwjfmZwzUrpUNfJPaVRwBpDY47A17yYEGWyRelnQ==

"@commitlint/cli@^7.1.2", "@commitlint/cli@^7.3.2":
version "7.3.2"
Expand Down