Skip to content

test(ts-estree): correct jsx for semantic-diagnostics tests #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2019
Merged

test(ts-estree): correct jsx for semantic-diagnostics tests #218

merged 1 commit into from
Feb 6, 2019

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Feb 6, 2019

files with js, jsx, tsx extensions should be parsed as "JSX" in semantic-diagnostics tests

@armano2 armano2 requested a review from JamesHenry February 6, 2019 01:28
@armano2 armano2 self-assigned this Feb 6, 2019
@armano2 armano2 added the package: typescript-estree Issues related to @typescript-eslint/typescript-estree label Feb 6, 2019
JamesHenry
JamesHenry approved these changes Feb 6, 2019
View reviewed changes
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@JamesHenry JamesHenry merged commit 690bff3 into typescript-eslint:master Feb 6, 2019
@armano2 armano2 deleted the test-semantic-jsx branch February 6, 2019 01:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees

@armano2 armano2

Labels
package: typescript-estree Issues related to @typescript-eslint/typescript-estree
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armano2 @JamesHenry