feat(ts-estree): enable 1098,1099 errors and add missing tests #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHenry
previously approved these changes
Feb 7, 2019
bradzacher
previously approved these changes
Feb 7, 2019
|
conflicts |
Codecov Report
@@ Coverage Diff @@
## master #219 +/- ##
==========================================
+ Coverage 96.77% 96.85% +0.08%
==========================================
Files 53 53
Lines 2478 2478
Branches 372 372
==========================================
+ Hits 2398 2400 +2
+ Misses 40 39 -1
+ Partials 40 39 -1
|
JamesHenry
approved these changes
Feb 7, 2019
kaicataldo
pushed a commit
to kaicataldo/typescript-eslint
that referenced
this pull request
Aug 27, 2019
…eslint#219) Fixes typescript-eslint#201 Fixes typescript-eslint#96 Fixes eslint/typescript-eslint-parser#577 The [base eslint implementation](https://github.com/eslint/eslint/blob/master/lib/rules/indent.js) purposely ignores nodes it doesn't know about (i.e. our TS nodes). Because of how the base rule is written, we have to override the implementation entirely.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables TS1098 and TS1099 error codes and adds tests cases for them.
babel/babel#9462