fix(eslint-plugin): [space-before-function-paren] handle abstract functions #2199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @adrielcodeco! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #2199 +/- ##
==========================================
- Coverage 93.39% 93.10% -0.30%
==========================================
Files 173 282 +109
Lines 7871 9017 +1146
Branches 2247 2465 +218
==========================================
+ Hits 7351 8395 +1044
- Misses 247 301 +54
- Partials 273 321 +48
|
|
@bradzacher Who is responsible for adding reviewers? |
|
It will be reviewed by maintainers when we are able |
bradzacher
reviewed
Jun 19, 2020
packages/eslint-plugin/src/rules/space-before-function-paren.ts
Outdated
Show resolved
Hide resolved
|
LGTM - thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(eslint-plugin): [space-before-function-paren] enable rule to abstract function (#2192)