Skip to content

fix(eslint-plugin): [no-namespace] allow namespaces in nested declarations with allowDeclarations #2238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 6, 2020
Merged

fix(eslint-plugin): [no-namespace] allow namespaces in nested declarations with allowDeclarations #2238

merged 5 commits into from
Jul 6, 2020

Conversation

cherryblossom000
Copy link
Contributor

Fixes #2237

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @cherryblossom000!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Jun 22, 2020 •
edited
Loading

Codecov Report

Merging #2238 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2238   +/-   ##
=======================================
  Coverage   93.29%   93.30%           
=======================================
  Files         173      173           
  Lines        7789     7792    +3     
  Branches     2284     2286    +2     
=======================================
+ Hits         7267     7270    +3     
  Misses        247      247           
  Partials      275      275
Flag Coverage Δ
#unittest 93.30% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/no-namespace.ts 100.00% <100.00%> (ø)

@bradzacher bradzacher changed the title fix(eslint-plugin): [no-namespace] allow namespaces in nested declarations with allowDeclarations (fixes #2237) feat(eslint-plugin): [no-namespace] allow namespaces in nested declarations with allowDeclarations Jun 22, 2020
@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Jun 22, 2020
@cherryblossom000 cherryblossom000 mentioned this pull request Jun 26, 2020
Closed
bradzacher
bradzacher approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher changed the title feat(eslint-plugin): [no-namespace] allow namespaces in nested declarations with allowDeclarations fix(eslint-plugin): [no-namespace] allow namespaces in nested declarations with allowDeclarations Jul 6, 2020
@bradzacher bradzacher added bug Something isn't working and removed enhancement: plugin rule option New rule option for an existing eslint-plugin rule labels Jul 6, 2020
@bradzacher bradzacher merged commit c1df669 into typescript-eslint:master Jul 6, 2020
@cherryblossom000 cherryblossom000 deleted the 2237 branch July 7, 2020 00:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[no-namespace] Allow namespaces in module and the global namespace augmentation
2 participants
@cherryblossom000 @bradzacher