feat: support ESTree optional chaining representation #2308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
8ba6e1c to
f31b792
Compare
f31b792 to
2411e6f
Compare
Codecov Report
@@ Coverage Diff @@
## v4 #2308 +/- ##
==========================================
- Coverage 93.09% 93.05% -0.05%
==========================================
Files 284 285 +1
Lines 9097 9109 +12
Branches 2499 2503 +4
==========================================
+ Hits 8469 8476 +7
- Misses 302 303 +1
- Partials 326 330 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bradzacher
added a commit
that referenced
this pull request
Aug 3, 2020
bradzacher
added a commit
that referenced
this pull request
Aug 9, 2020
bradzacher
added a commit
that referenced
this pull request
Aug 10, 2020
bradzacher
added a commit
that referenced
this pull request
Aug 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
This changes the AST structure to the new ESTree representation for optional chaining.
typesvisitor-keysscope-managertypescript-estreeparserexperimental-utilseslint-plugineslint-plugin-internalI also ran a quick sanity "integration test" by linking
@typescript-eslint/parserinto a checkout of theeslintrepo to ensure that tests were passing fine there.Fixes #2204