-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
v4.0.0 breaking changes #2330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4.0.0 breaking changes #2330
Conversation
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #2330 +/- ##
==========================================
- Coverage 93.16% 92.94% -0.22%
==========================================
Files 287 289 +2
Lines 9186 9272 +86
Branches 2528 2583 +55
==========================================
+ Hits 8558 8618 +60
- Misses 301 320 +19
- Partials 327 334 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
cf29440
to
12b9c8a
Compare
Just as a heads up - I was planning on merging this today, however due to the TS 4.0 release, we had to bump the version ranges. I don't want to force people to do a major version upgrade to remove the console logs, so I'm going to delay this slightly. |
BREAKING CHANGE: - Removed decorators property from several Nodes that could never semantically have them (FunctionDeclaration, TSEnumDeclaration, and TSInterfaceDeclaration) - Removed AST_NODE_TYPES.Import. This is a minor breaking change as the node type that used this was removed ages ago.
…ntheses and non-nulls (#2380)
…sions] add option to make the rules error on files without `strictNullChecks` turned on (#2345)
Fixes #2398 If the user has a particularly large node_modules folder and uses globs for `parserOption.project`, then the `glob` library can spend a decent chunk of time searching the `node_modules` folder. In some cases, this can be on the order of hundreds to thousands of milliseconds. This wouldn't be a problem, but for safety and correctness during a persistent parse, we have to do this check for every call to the parser (i.e. every file that's being linted). Over a whole project, this can easily add up to many, many seconds wasted. Previously, we: - applied the project globs, one by one - then manually excluded `tsconfig`s from the list. This meant that we are always slow. I remember I did this because I had issues getting `glob`'s `ignore` option to work at all. ## The solution `globby` is a better glob library: - it accepts an array of globs, which saves us doing manual looping - it supports exclusion globs (globs prefixed with `!`), which are evaluated as part of the glob process - it has caching built in by default This allows us to evaluate all of the `project` globs at once, as opposed to one at a time (so should be less duplicated work). This also allows us to evaluate the `projectFolderIgnoreList` at the same time as the `project` globs (so should be no useless work done). All of these together should cut the glob evaluation time down to ~50ms for the first parse, and ~2ms for each parse after that (due to caching). For comparison, previously, in bad cases we would spend ~3-500ms, per project, per parsed file. Example to illustrate how much faster this can potentially be: For a project that provides 2 globs and has 100 files. Before: 300ms * 2 * 100 = 60,000ms (60s) After: 50ms + 2 * 100 = 250ms This should also save a non-trival amount of time in other, more optimal setups. BREAKING CHANGE: - removes the ability to supply a `RegExp` to `projectFolderIgnoreList`, and changes the meaning of the string value from a regex to a glob.
fce692b
to
f7a7712
Compare
BREAKING CHANGE:
This is just a PR to increase visibility of breaking changes that are will be merged for the upcoming 4.0.0 release.
We will rebase merge this PR into master to preserve the history.
These changes are available on NPM under the
rc-v4
tagRelease notes:
https://github.com/typescript-eslint/typescript-eslint/releases/tag/v4.0.0-rc