-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(eslint-plugin): [typedef] remove all defaults #2352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## v4 #2352 +/- ##
==========================================
- Coverage 92.97% 92.97% -0.01%
==========================================
Files 285 285
Lines 9014 9013 -1
Branches 2510 2510
==========================================
- Hits 8381 8380 -1
Misses 304 304
Partials 329 329
Flags with carried forward coverage won't be shown. Click here to find out more.
|
BREAKING CHANGE:
Removes all default options from
typedef
. Users will have to specifically opt-in to all options them selves.This is intentional friction being introduced to setup the rule to help discourage it as it's not recommended for use.
This also ensures this rule cannot conflict with any other rules (or even do anything) in the
all
config.Fixes #2075