Skip to content

docs: document additional allow options in no-empty-function #2379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mdziekon
Copy link
Contributor

@mdziekon mdziekon commented Aug 9, 2020

This PR adds missing pieces of the no-empty-function documentation, where the TS-specific allow entries were completely omitted. It adds both a general overview of the extended Options object (as pseudo-code), and per entry descriptions with examples (taken directly from test cases).

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @mdziekon!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this!

@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Aug 9, 2020
@bradzacher bradzacher merged commit 30993cd into typescript-eslint:master Aug 9, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants