Skip to content

fix(eslint-plugin): [no-unnecessary-condition] better handling for unary negation #2382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 24, 2020
Merged

fix(eslint-plugin): [no-unnecessary-condition] better handling for unary negation #2382

merged 6 commits into from
Aug 24, 2020

Conversation

renugasaraswathy
Copy link
Contributor

Fixes #2255

Added handing for unary negation expression.
cc @bradzacher

Please let me know if any change is required.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @renugasaraswathy!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Aug 10, 2020 •
edited
Loading

Codecov Report

Merging #2382 into master will decrease coverage by 0.01%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##           master    #2382      +/-   ##
==========================================
- Coverage   93.16%   93.15%   -0.02%     
==========================================
  Files         286      286              
  Lines        9161     9174      +13     
  Branches     2517     2524       +7     
==========================================
+ Hits         8535     8546      +11     
  Misses        301      301              
- Partials      325      327       +2
Flag Coverage Δ
#unittest 93.15% <84.61%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...slint-plugin/src/rules/no-unnecessary-condition.ts 96.02% <84.61%> (-0.91%) ⬇️

@renugasaraswathy
Copy link
Contributor Author

Will work on the code coverage and push.

@bradzacher bradzacher added bug Something isn't working awaiting response Issues waiting for a reply from the OP or another party labels Aug 10, 2020
@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Aug 16, 2020
bradzacher
bradzacher approved these changes Aug 24, 2020
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher changed the title fix(eslint-plugin): Handling unary negation expression in no-unnecessary-condition fix(eslint-plugin): [no-unnecessary-condition] better handling for unary negation Aug 24, 2020
@bradzacher bradzacher merged commit 32fe2bb into typescript-eslint:master Aug 24, 2020
@bradzacher bradzacher mentioned this pull request Aug 24, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[no-unnecessary-condition] False positive for nested arrays
2 participants
@renugasaraswathy @bradzacher