Skip to content

docs(eslint-plugin): [type-annotation-spacing] typo #2392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2020
Merged

docs(eslint-plugin): [type-annotation-spacing] typo #2392

merged 1 commit into from
Aug 14, 2020

Conversation

koooge
Copy link
Contributor

@koooge koooge commented Aug 13, 2020

Fix @typescript-eslint/type-annotation-spacing examples with 'allow'

@koooge
fix: Fix doc type-annotation-spacing
137aab9 
Signed-off-by: koooge <koooooge@gmail.com>
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @koooge!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

koooge
koooge commented Aug 13, 2020
View reviewed changes
packages/eslint-plugin/docs/rules/type-annotation-spacing.md
```

Examples of **correct** code for this rule with `{ "before": true, "after": true, overrides: { colon: { before: true, after: true }} }` options:
Examples of **correct** code for this rule with `{ "before": false, "after": false, overrides: { colon: { before: true, after: true }} }` options:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the point

@codecov
Copy link

codecov bot commented Aug 13, 2020 •
edited
Loading

Codecov Report

Merging #2392 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2392   +/-   ##
=======================================
  Coverage   93.16%   93.16%           
=======================================
  Files         286      286           
  Lines        9161     9161           
  Branches     2517     2517           
=======================================
  Hits         8535     8535           
  Misses        301      301           
  Partials      325      325
Flag Coverage Δ
#unittest 93.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

bradzacher
bradzacher approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Aug 14, 2020
@bradzacher bradzacher changed the title docs(eslint-plugin): fFix doc type-annotation-spacing docs(eslint-plugin): [type-annotation-spacing] typo Aug 14, 2020
@bradzacher bradzacher merged commit daf649f into typescript-eslint:master Aug 14, 2020
@koooge koooge deleted the fix/doc_space branch August 14, 2020 17:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koooge @bradzacher