Skip to content

test(eslint-plugin): add test cases for eslint rules #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 11, 2019
Merged

test(eslint-plugin): add test cases for eslint rules #240

merged 4 commits into from
Feb 11, 2019

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Feb 10, 2019 •
edited
Loading

This PR adds regression tests for eslint core rules

@armano2 armano2 self-assigned this Feb 10, 2019
@armano2 armano2 changed the title fix(eslint-plugin): add test cases for eslint rules test(eslint-plugin): add test cases for eslint rules Feb 10, 2019
@armano2 armano2 mentioned this pull request Feb 11, 2019
Closed
8 tasks
@armano2 armano2 requested a review from bradzacher February 11, 2019 02:45
bradzacher
bradzacher previously approved these changes Feb 11, 2019
View reviewed changes
packages/eslint-plugin/tests/eslint-rules/no-redeclare.test.ts
{
message: "'a' is already defined.",
type: AST_NODE_TYPES.Identifier
} as any
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh, we should consider PRing the base eslint to migrate their rules to messageId

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup we should :)

@bradzacher bradzacher merged commit f44783c into typescript-eslint:master Feb 11, 2019
@armano2 armano2 deleted the eslint-rules branch February 11, 2019 18:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees

@armano2 armano2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armano2 @bradzacher