fix(eslint-plugin): [explicit-module-boundary-types] ignore all bodyless setters #2413
Conversation
|
Thanks for the PR, @vansergen! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #2413 +/- ##
==========================================
- Coverage 93.14% 93.13% -0.02%
==========================================
Files 287 287
Lines 9175 9176 +1
Branches 2522 2523 +1
==========================================
Hits 8546 8546
Misses 302 302
- Partials 327 328 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
The test you added doesn't fire the code you changed. The function you changed specifically for empty body functions - i.e. function signatures.
I believe that test should instead be something like:
declare class Foo {
set bar(value: string);
}
export { Foo };
Related PR #2410