-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(eslint-plugin): add extension rule comma-dangle
#2416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR, @yeonjuan! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #2416 +/- ##
=======================================
Coverage 92.82% 92.82%
=======================================
Files 290 291 +1
Lines 9506 9551 +45
Branches 2664 2676 +12
=======================================
+ Hits 8824 8866 +42
- Misses 323 324 +1
- Partials 359 361 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly lgtm! typo in the docs
Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
@bradzacher Oh. it's my bad. Thanks :) |
# Conflicts: # packages/eslint-plugin/README.md
This comment has been minimized.
This comment has been minimized.
When I've got time to review larger feature PRs, I'll get to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for your contribution!
fixes #710