Skip to content

feat(eslint-plugin): [no-invalid-void-type] add option to allow this: void #2481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 28, 2020
Merged

feat(eslint-plugin): [no-invalid-void-type] add option to allow this: void #2481

merged 6 commits into from
Sep 28, 2020

Conversation

tadhgmister
Copy link
Contributor

Fixes: #2148

adds option to allow using a this parameter to void, while I'd like to set it enabled by default that would complicate the test cases since it changes most of the error messages so I left it disabled by default.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @tadhgmister!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Sep 3, 2020
@codecov
Copy link

codecov bot commented Sep 3, 2020 •
edited
Loading

Codecov Report

Merging #2481 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2481   +/-   ##
=======================================
  Coverage   92.83%   92.83%           
=======================================
  Files         292      292           
  Lines        9571     9578    +7     
  Branches     2680     2686    +6     
=======================================
+ Hits         8885     8892    +7     
  Misses        324      324           
  Partials      362      362
Flag Coverage Δ
#unittest 92.83% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/eslint-plugin/src/rules/no-invalid-void-type.ts 95.34% <ø> (+0.90%) ⬆️

bradzacher
bradzacher requested changes Sep 21, 2020
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks for your contribution.
one comment on the docs

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Sep 21, 2020
@bradzacher bradzacher changed the title feat[eslint-plugin]: [no-invalid-void-type] add option to allow this: void feat(eslint-plugin): [no-invalid-void-type] add option to allow this: void Sep 21, 2020
@bradzacher bradzacher changed the title feat(eslint-plugin): [no-invalid-void-type] add option to allow this: void feat(eslint-plugin): [no-invalid-void-type] add option to allow this: void Sep 21, 2020
tadhgmister pushed a commit to tadhgmister/typescript-eslint that referenced this pull request Sep 21, 2020
addresses typescript-eslint#2430 and typescript-eslint#2481
81ca186
@tadhgmister tadhgmister mentioned this pull request Sep 21, 2020
Closed
tadhgmister pushed a commit to tadhgmister/typescript-eslint that referenced this pull request Sep 21, 2020
addresses typescript-eslint#2430 and typescript-eslint#2481
fed30ba
@tadhgmister tadhgmister mentioned this pull request Sep 22, 2020
Closed
@tadhgmister
Copy link
Contributor Author

Based on this response I'd like one reconsider if you want me to change the wording, if you still think the word "recommends" is too strong I'll change it but I really think the docs as I wrote it is the correct way of phrasing it.

@bradzacher bradzacher added awaiting response Issues waiting for a reply from the OP or another party and removed awaiting response Issues waiting for a reply from the OP or another party labels Sep 28, 2020
@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Sep 28, 2020
bradzacher
bradzacher approved these changes Sep 28, 2020
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@bradzacher bradzacher merged commit ddf5660 into typescript-eslint:master Sep 28, 2020
@tadhgmister tadhgmister deleted the thisVoidFix branch September 28, 2020 18:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[no-invalid-void-type] Should allow this: void
2 participants
@tadhgmister @bradzacher