feat(eslint-plugin): add no-unnecessary-type-constraint rule
#2516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
e0ee9ae to
23e14f2
Compare
Codecov Report
@@ Coverage Diff @@
## master #2516 +/- ##
==========================================
- Coverage 92.81% 92.75% -0.07%
==========================================
Files 290 296 +6
Lines 9453 9739 +286
Branches 2647 2733 +86
==========================================
+ Hits 8774 9033 +259
- Misses 322 332 +10
- Partials 357 374 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
23e14f2 to
592e282
Compare
JoshuaKGoldberg
commented
Sep 8, 2020
This was referenced Sep 15, 2020
bradzacher
requested changes
Sep 28, 2020
packages/eslint-plugin/src/rules/no-unnecessary-type-constraint.ts
Outdated
Show resolved
Hide resolved
packages/eslint-plugin/src/rules/no-unnecessary-type-constraint.ts
Outdated
Show resolved
Hide resolved
packages/eslint-plugin/src/rules/no-unnecessary-type-constraint.ts
Outdated
Show resolved
Hide resolved
no-unnecessary-type-constraint rule
bradzacher
requested changes
Oct 18, 2020
packages/eslint-plugin/tests/rules/no-unnecessary-type-constraint.test.ts
Outdated
Show resolved
Hide resolved
This was referenced Oct 26, 2020
This was referenced Oct 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2107.
If a type parameter inside a type parameter declaration includes a constraint and that constraint includes the
AnyorUnknownflag, that's an error.