Skip to content

docs(eslint-plugin): added missing no-restricted-globals to ban in ROADMAP.md #2564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2020
Merged

docs(eslint-plugin): added missing no-restricted-globals to ban in ROADMAP.md #2564

merged 1 commit into from
Sep 15, 2020

Conversation

JoshuaKGoldberg
Copy link
Member

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #2564 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2564   +/-   ##
=======================================
  Coverage   92.81%   92.82%           
=======================================
  Files         290      290           
  Lines        9453     9505   +52     
  Branches     2647     2664   +17     
=======================================
+ Hits         8774     8823   +49     
- Misses        322      323    +1     
- Partials      357      359    +2
Flag Coverage Δ
#unittest 92.82% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/no-implied-eval.ts 93.75% <0.00%> (-2.81%) ⬇️
packages/eslint-plugin/src/rules/return-await.ts 95.69% <0.00%> (-0.08%) ⬇️
packages/experimental-utils/src/ts-eslint/Scope.ts 100.00% <0.00%> (ø)
...es/eslint-plugin/src/rules/no-use-before-define.ts 94.36% <0.00%> (ø)
...kages/eslint-plugin/src/rules/naming-convention.ts 89.30% <0.00%> (+0.14%) ⬆️
packages/eslint-plugin/src/rules/no-unused-vars.ts 93.06% <0.00%> (+0.21%) ⬆️
...es/eslint-plugin/src/rules/prefer-function-type.ts 96.29% <0.00%> (+1.17%) ⬆️

@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Sep 15, 2020
bradzacher
bradzacher approved these changes Sep 15, 2020
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bradzacher bradzacher changed the title docs(eslint-plugin): added missing no-restricted-globals to ban in ROADMAP.md docs(eslint-plugin): added missing no-restricted-globals to ban in ROADMAP.md Sep 15, 2020
@bradzacher bradzacher merged commit 41d4a47 into typescript-eslint:master Sep 15, 2020
@JoshuaKGoldberg JoshuaKGoldberg deleted the roadmap-ban branch September 15, 2020 04:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Roadmap missing ESLint's no-restricted-globals for TSLint's ban
2 participants
@JoshuaKGoldberg @bradzacher