-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(eslint-plugin): added safe getTypeOfPropertyOfType wrapper #2567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): added safe getTypeOfPropertyOfType wrapper #2567
Conversation
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
We should add a lint rule for this to warn against using the method directly. Could expand this internal lint rule to cover it: |
TBD whether this original approach works, but it would also be nice to not use an internal TypeScript compiler API... I'd be interested in looking at that too. |
Codecov Report
@@ Coverage Diff @@
## master #2567 +/- ##
==========================================
- Coverage 92.82% 92.82% -0.01%
==========================================
Files 290 291 +1
Lines 9505 9514 +9
Branches 2664 2666 +2
==========================================
+ Hits 8823 8831 +8
Misses 323 323
- Partials 359 360 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for fixing this!
Fixes #2143. A quick find-all on
getTypeOfPropertyOfType
showed that the bug might also be able to pop up inno-unnecessary-condition
as well.