Skip to content

docs(eslint-plugin): missing info how to use sections, cjson -> jsonc #2578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 27, 2020
Merged

docs(eslint-plugin): missing info how to use sections, cjson -> jsonc #2578

merged 2 commits into from
Sep 27, 2020

Conversation

radarsu
Copy link
Contributor

@radarsu radarsu commented Sep 18, 2020 •
edited
Loading

Fixes #2555

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @radarsu!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@radarsu radarsu mentioned this pull request Sep 21, 2020
Closed
3 tasks
@tadhgmister
Copy link
Contributor

would you mind editing the initial comment to say "Fixes #2555", that way when this gets merged it will automatically close the relevant issue. Thanks for this 👍

@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Sep 25, 2020
@radarsu
Copy link
Contributor Author

radarsu commented Sep 25, 2020

Done.

@tadhgmister
Copy link
Contributor

tadhgmister commented Sep 25, 2020 •
edited
Loading

you can still have additional info, just prefixing the issue label with "fixes" means GitHub does linking stuff like on the original issue page doing a control+f for "inked a pull request that will close this issue" and "Linked pull requests" show the relevant places. Also means it auto-closes the issue so you don't have to do it manually. (or forget) 😄

you can still have details like "changes cjson to jsonc" and the reasons is still applicable if you wanted to put that back.

bradzacher
bradzacher approved these changes Sep 27, 2020
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this!

@bradzacher bradzacher merged commit 16ffa47 into typescript-eslint:master Sep 27, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
3 participants
@radarsu @tadhgmister @bradzacher