-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(eslint-plugin): [ban-ts-comment] support block comments #2644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR, @dopecodez! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #2644 +/- ##
==========================================
+ Coverage 92.80% 92.83% +0.03%
==========================================
Files 293 294 +1
Lines 9604 9674 +70
Branches 2711 2713 +2
==========================================
+ Hits 8913 8981 +68
- Misses 326 327 +1
- Partials 365 366 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@bradzacher , I can see |
codecov is average yeah. sometimes it doesn't work. sometimes it's kinda flaky. it's also just slow sometimes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - thanks for your contribution!
Fixes #2617
Overview
The support for
ban-ts-comment
was restricted to only single line comments.This PR looks to expand the support for
ban-ts-comment
for block comments also.Approach
The approach revolved around changing the regex for recognizing the valid cases of @ts- commands and also changing how we handled comparing this regex and our comment.
Checklist