fix(eslint-plugin): [method-signature-style] correct fixer for overloads in an object literal type #2708

a-tarasyuk · 2020-10-25T21:09:04Z

typescript-eslint · 2020-10-25T21:09:08Z

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

codecov · 2020-10-25T21:20:13Z

Codecov Report

Merging #2708 into master will decrease coverage by 0.01%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master    #2708      +/-   ##
==========================================
- Coverage   92.78%   92.76%   -0.02%     
==========================================
  Files         295      295              
  Lines        9712     9716       +4     
  Branches     2725     2727       +2     
==========================================
+ Hits         9011     9013       +2     
  Misses        331      331              
- Partials      370      372       +2

Flag	Coverage Δ
#unittest	`92.76% <57.14%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../eslint-plugin/src/rules/method-signature-style.ts	`87.20% <57.14%> (-1.82%)`	⬇️

bradzacher

LGTM - thanks for fixing this!

fix(eslint-plugin): [method-signature-style] handle LiteralType

20d58a5

bradzacher added the bug Something isn't working label Oct 25, 2020

bradzacher approved these changes Oct 25, 2020

View reviewed changes

bradzacher changed the title ~~fix(eslint-plugin): [method-signature-style] handle LiteralType~~ fix(eslint-plugin): [method-signature-style] correct fixer for overloads in an object literal type Oct 25, 2020

bradzacher merged commit 0763913 into typescript-eslint:master Oct 25, 2020

github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(eslint-plugin): [method-signature-style] correct fixer for overloads in an object literal type #2708

fix(eslint-plugin): [method-signature-style] correct fixer for overloads in an object literal type #2708

a-tarasyuk commented Oct 25, 2020

typescript-eslint bot commented Oct 25, 2020

codecov bot commented Oct 25, 2020

bradzacher left a comment

fix(eslint-plugin): [method-signature-style] correct fixer for overloads in an object literal type #2708

fix(eslint-plugin): [method-signature-style] correct fixer for overloads in an object literal type #2708

Conversation

a-tarasyuk commented Oct 25, 2020

typescript-eslint bot commented Oct 25, 2020

codecov bot commented Oct 25, 2020

Codecov Report

bradzacher left a comment

Choose a reason for hiding this comment