refactor(ts-estree): simply convertToken and remove dead code #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
==========================================
+ Coverage 94.86% 94.96% +0.09%
==========================================
Files 67 67
Lines 2807 2803 -4
Branches 726 724 -2
==========================================
- Hits 2663 2662 -1
+ Misses 55 54 -1
+ Partials 89 87 -2
|
bradzacher
approved these changes
Feb 14, 2019
existentialism
approved these changes
Feb 14, 2019
kaicataldo
pushed a commit
to kaicataldo/typescript-eslint
that referenced
this pull request
Aug 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR removes invalid token type
JSXMemberExpression, its left over from #197before it was used to convert nodes and this case is not able to happens anymore.
i forgot to remove it