Skip to content

docs(eslint-plugin): Move no-implied-eval & no-throw-literal to Extension Rules #2745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2020
Merged

docs(eslint-plugin): Move no-implied-eval & no-throw-literal to Extension Rules #2745

merged 1 commit into from
Nov 8, 2020

Conversation

MichaelDeBoey
Copy link
Contributor

No description provided.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @MichaelDeBoey!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@MichaelDeBoey MichaelDeBoey mentioned this pull request Nov 7, 2020
Merged
bradzacher
bradzacher requested changes Nov 7, 2020
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can do this instead by setting extendsBaseRule: true in the rule's metadata. Example (no-shadow):

typescript-eslint/packages/eslint-plugin/src/rules/no-shadow.ts

Line 29 in e82698c

extendsBaseRule: true,

Then run yarn generate:rules-lists to update the markdown table appropriately

@MichaelDeBoey MichaelDeBoey force-pushed the patch-1 branch 2 times, most recently from 2013f73 to 4a7116a Compare November 7, 2020 01:38
bradzacher
bradzacher approved these changes Nov 8, 2020
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this!

@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Nov 8, 2020
@bradzacher bradzacher merged commit 0d0af64 into typescript-eslint:master Nov 8, 2020
@MichaelDeBoey
Copy link
Contributor Author

Always a pleasure to help out 🙂

@MichaelDeBoey MichaelDeBoey deleted the patch-1 branch November 9, 2020 00:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelDeBoey @bradzacher