fix(eslint-plugin): [triple-slash-reference] fix crash with external module reference #2788
Conversation
…n that module reference is always TSExternalModuleReference
|
Thanks for the PR, @ddubrava! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #2788 +/- ##
==========================================
- Coverage 92.79% 92.79% -0.01%
==========================================
Files 297 300 +3
Lines 9833 9858 +25
Branches 2762 2770 +8
==========================================
+ Hits 9125 9148 +23
Misses 332 332
- Partials 376 378 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| case AST_NODE_TYPES.Identifier: | ||
| value = source.name; | ||
| break; | ||
|
|
||
| case AST_NODE_TYPES.TSQualifiedName: | ||
| value = (source.left as TSESTree.Identifier).name; | ||
| break; |
There was a problem hiding this comment.
I think we should just completely ignore these cases by returning early instead.
There's no import source to compare against here, so doing so will likely lead to some weirdness.
…ssumption that module reference is always TSExternalModuleReference" This reverts commit f1ecd2b.
fixes #2762
https://astexplorer.net/#/gist/cde0bd7d85e03d135e604e7913a999cd/c034332f4ccf256e809629b0552578191e38b3fe
I'm not sure about the solution cuz it's weird that there was used
as TSESTree.TSExternalModuleReferenceand didn't handle any other types considering thatmoduleReferencehas already been typed.