feat(eslint-plugin): [naming-convention] add requireDouble, allowDouble, allowSingleOrDouble options for underscores
#2812
Conversation
|
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #2812 +/- ##
==========================================
+ Coverage 92.74% 92.76% +0.01%
==========================================
Files 301 301
Lines 10232 10257 +25
Branches 2902 2905 +3
==========================================
+ Hits 9490 9515 +25
Misses 344 344
Partials 398 398
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…ouble`, `allowSingleOrDouble` options for underscores Fixes #1712 I chose not to add an unbounded `allowMultiple` for now. I don't think that it's a commonly used pattern. Single and double I've seen, but I don't believe I've ever seen more than that.
dc26c17 to
e164bf6
Compare
Fixes #1712
I chose not to add an unbounded
allowMultiplefor now. I don't think that it's a commonly used pattern.Single and double I've seen, but I don't believe I've ever seen more than that.
I'd like to avoid adding something unbounded unless there's a strong usecase for it.