Skip to content

feat(eslint-plugin): [naming-convention] add import selector #2815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

bradzacher
Copy link
Member

Fixes #2106

This is a work in progress.

@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Nov 25, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the DO NOT MERGE PRs which should not be merged yet label Jul 31, 2021
@JoshuaKGoldberg
Copy link
Member

👋 @bradzacher, just checking in - still interested in this PR?

@bradzacher
Copy link
Member Author

I think this still makes sense to have.
Some people have the preference to name imports the same as their module name - which naming-convention can't enforce, but there are other rules for that.

I think that for those that don't care about matching - it would be useful to be able to enforce naming of the imports.
It's been super low pri for me though as there's not huge amount of call from the community for this.

@bradzacher
Copy link
Member Author

Closing for housekeeping purposes.
Anyone is free to raise a fresh PR to continue this work!

@bradzacher bradzacher closed this Mar 4, 2022
@bradzacher bradzacher added the stale PRs or Issues that are at risk of being or have been closed due to inactivity for a prolonged period label Mar 4, 2022
@bradzacher bradzacher deleted the naming-convention-imports branch March 4, 2022 07:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DO NOT MERGE PRs which should not be merged yet enhancement: plugin rule option New rule option for an existing eslint-plugin rule stale PRs or Issues that are at risk of being or have been closed due to inactivity for a prolonged period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[naming-convention] Add the ability to lint imports
2 participants