chore(eslint-plugin): [naming-convention] refactor rule to split it up #2816
Conversation
|
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
The rule file was up to 1700 LOC. It was a pain in the butt to scroll around it and find pieces. I'm pretty sure ESLint / TypeScript gets a bit choked up on a file that large as well (I've been running into all sorts of slowness with it). So simply isolate each part into a module to better separate things and reduce the total LOC per file. Also moved some stuff around in the docs to try and focus each section, and add an FAQ section for the misc stuff
504866c to
18bf372
Compare
Codecov Report
@@ Coverage Diff @@
## master #2816 +/- ##
==========================================
- Coverage 92.74% 92.74% -0.01%
==========================================
Files 302 309 +7
Lines 10269 10320 +51
Branches 2909 2920 +11
==========================================
+ Hits 9524 9571 +47
Misses 346 346
- Partials 399 403 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The rule file was up to 1700 LOC.
It was a pain in the butt to scroll around it and find pieces.
I'm pretty sure ESLint / TypeScript gets a bit choked up on a file that large as well (I've been running into all sorts of slowness with it).
So simply isolate each part into a module to better separate things and reduce the total LOC per file.
Also moved some stuff around in the docs to try and focus each section, and add an FAQ section for the misc stuff