feat(eslint-plugin): add prefer-string-starts-ends-with rule (fixes #285) #289

mysticatea · 2019-02-16T07:43:00Z

Fixes #285.

This PR adds a new rule: @typescript-eslint/prefer-string-starts-ends-with.
(probably there are better names)

This PR adds two dependencies: eslint-utils and regexpp. Don't warry, eslint has depended on those packages already, so this add will not increase install time and disk size.
This PR fixes some internal types for more correct.

)

codecov · 2019-02-16T07:50:13Z

Codecov Report

Merging #289 into master will increase coverage by 0.17%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
+ Coverage   96.96%   97.14%   +0.17%     
==========================================
  Files          72       73       +1     
  Lines        2705     2868     +163     
  Branches      436      473      +37     
==========================================
+ Hits         2623     2786     +163     
  Misses         49       49              
  Partials       33       33

Impacted Files	Coverage Δ
...plugin/src/rules/prefer-string-starts-ends-with.ts	`100% <100%> (ø)`

…s-ends-with/new

The return value of `s.match` is an `Array` object or `null`.

packages/eslint-plugin/docs/rules/prefer-string-starts-ends-with.md

…th.md Co-Authored-By: mysticatea <star.ctor@gmail.com>

some test cases were rejected by node selectors unintentionally.

…s-ends-with/new # Conflicts: # packages/eslint-plugin/package.json # packages/eslint-plugin/typings/ts-eslint.d.ts

packages/eslint-plugin/src/rules/prefer-string-starts-ends-with.ts

packages/eslint-plugin/docs/rules/prefer-string-starts-ends-with.md

…h.ts Co-Authored-By: mysticatea <star.ctor@gmail.com>

…th.md Co-Authored-By: mysticatea <star.ctor@gmail.com>

packages/eslint-plugin/tests/RuleTester.ts

packages/eslint-plugin/docs/rules/prefer-string-starts-ends-with.md

packages/eslint-plugin/src/rules/prefer-string-starts-ends-with.ts

…th.md Co-Authored-By: mysticatea <star.ctor@gmail.com>

mysticatea · 2019-02-23T17:24:57Z

Thank you for the review!
I updated this PR.

…s-ends-with/new # Conflicts: # packages/eslint-plugin/package.json

mysticatea · 2019-03-06T04:33:14Z

@JamesHenry Would you review again?

bradzacher

two nits otherwise LGTM

packages/eslint-plugin/src/rules/prefer-string-starts-ends-with.ts

JamesHenry

If @bradzacher comments could be addressed and the conflicts resolved then this looks great!

# Conflicts: # packages/eslint-plugin/package.json

mysticatea · 2019-04-09T10:28:28Z

I apologize for my late response. I updated this PR.

teppeis · 2019-04-25T14:50:32Z

@mysticatea Supported Rules
in README are not updated.
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/README.md

fregante · 2020-03-16T11:01:18Z

This rule can now also extended to include string | undefined:

/^wow/.test(stringOrUndefined!);
// becomes
stringOrUndefined?.startsWith('wow')

fregante · 2020-03-16T13:59:28Z

On second thought, no, because the former returns boolean while the latter is boolean | undefined

feat(eslint-plugin): add prefer-string-starts-ends-with rule (fixes #285

0a10459

)

mysticatea added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin enhancement: new plugin rule New rule request for eslint-plugin labels Feb 16, 2019

mysticatea mentioned this pull request Feb 18, 2019

feat(eslint-plugin): add prefer-includes rule (fixes #284) #294

Merged

mysticatea added 3 commits February 19, 2019 15:18

Merge remote-tracking branch 'origin/master' into prefer-string-start…

fcb945a

…s-ends-with/new

fix s.match behavior

ee7c1df

The return value of `s.match` is an `Array` object or `null`.

fix formating errors

34e9fe1

sindresorhus suggested changes Feb 19, 2019

View reviewed changes

packages/eslint-plugin/docs/rules/prefer-string-starts-ends-with.md Outdated Show resolved Hide resolved

sindresorhus and others added 4 commits February 19, 2019 16:17

Update packages/eslint-plugin/docs/rules/prefer-string-starts-ends-wi…

c39407a

…th.md Co-Authored-By: mysticatea <star.ctor@gmail.com>

fix for coverage 100

4cd6097

some test cases were rejected by node selectors unintentionally.

Merge remote-tracking branch 'origin/master' into prefer-string-start…

740fe07

…s-ends-with/new # Conflicts: # packages/eslint-plugin/package.json # packages/eslint-plugin/typings/ts-eslint.d.ts

fix format as following master branch

881a3e4

ldrick reviewed Feb 21, 2019

View reviewed changes

packages/eslint-plugin/src/rules/prefer-string-starts-ends-with.ts Show resolved Hide resolved

j-f1 reviewed Feb 21, 2019

View reviewed changes

packages/eslint-plugin/src/rules/prefer-string-starts-ends-with.ts Outdated Show resolved Hide resolved

packages/eslint-plugin/src/rules/prefer-string-starts-ends-with.ts Outdated Show resolved Hide resolved

ldrick mentioned this pull request Feb 21, 2019

feat(eslint-plugin): add prefer-regexp-exec rule #305

Merged

existentialism reviewed Feb 21, 2019

View reviewed changes

packages/eslint-plugin/docs/rules/prefer-string-starts-ends-with.md Outdated Show resolved Hide resolved

existentialism reviewed Feb 21, 2019

View reviewed changes

packages/eslint-plugin/docs/rules/prefer-string-starts-ends-with.md Outdated Show resolved Hide resolved

j-f1 and others added 4 commits February 22, 2019 13:48

Update packages/eslint-plugin/src/rules/prefer-string-starts-ends-wit…

08ab0ad

…h.ts Co-Authored-By: mysticatea <star.ctor@gmail.com>

Update packages/eslint-plugin/src/rules/prefer-string-starts-ends-wit…

86018fd

…h.ts Co-Authored-By: mysticatea <star.ctor@gmail.com>

Update packages/eslint-plugin/docs/rules/prefer-string-starts-ends-wi…

3c1def5

…th.md Co-Authored-By: mysticatea <star.ctor@gmail.com>

Update packages/eslint-plugin/docs/rules/prefer-string-starts-ends-wi…

38005cd

…th.md Co-Authored-By: mysticatea <star.ctor@gmail.com>

JamesHenry reviewed Feb 23, 2019

View reviewed changes

packages/eslint-plugin/tests/RuleTester.ts Show resolved Hide resolved

JamesHenry reviewed Feb 23, 2019

View reviewed changes

packages/eslint-plugin/docs/rules/prefer-string-starts-ends-with.md Outdated Show resolved Hide resolved

Merge branch 'master' into prefer-string-starts-ends-with/new

c113c9c

JamesHenry requested changes Feb 23, 2019

View reviewed changes

packages/eslint-plugin/src/rules/prefer-string-starts-ends-with.ts Outdated Show resolved Hide resolved

JamesHenry and others added 4 commits February 24, 2019 02:16

Update packages/eslint-plugin/docs/rules/prefer-string-starts-ends-wi…

ef3e7d6

…th.md Co-Authored-By: mysticatea <star.ctor@gmail.com>

remove comment

ab1dd85

update description

671edd6

update example

fecf943

Merge remote-tracking branch 'origin/master' into prefer-string-start…

e15a7ff

…s-ends-with/new # Conflicts: # packages/eslint-plugin/package.json

mysticatea mentioned this pull request Mar 5, 2019

feat(eslint-plugin): Make explicit-member-accessibility fixable #331

Closed

Merge branch 'master' into prefer-string-starts-ends-with/new

ef0daaf

bradzacher reviewed Mar 8, 2019

View reviewed changes

packages/eslint-plugin/src/rules/prefer-string-starts-ends-with.ts Outdated Show resolved Hide resolved

packages/eslint-plugin/src/rules/prefer-string-starts-ends-with.ts Outdated Show resolved Hide resolved

Merge branch 'master' into prefer-string-starts-ends-with/new

150dd9a

JamesHenry previously approved these changes Apr 4, 2019

View reviewed changes

JamesHenry added the awaiting response Issues waiting for a reply from the OP or another party label Apr 4, 2019

mysticatea added 2 commits April 9, 2019 19:19

Merge branch 'master' into prefer-string-starts-ends-with/new

081a338

# Conflicts: # packages/eslint-plugin/package.json

fix for review

872ed49

mysticatea dismissed JamesHenry’s stale review via 872ed49 April 9, 2019 10:26

bradzacher approved these changes Apr 11, 2019

View reviewed changes

bradzacher added 2 commits April 10, 2019 17:46

Merge branch 'master' into prefer-string-starts-ends-with/new

f955b79

Merge branch 'master' into prefer-string-starts-ends-with/new

b86eba7

bradzacher merged commit 5592a2c into master Apr 11, 2019

bradzacher deleted the prefer-string-starts-ends-with/new branch April 11, 2019 01:18

bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Apr 13, 2020

github-actions bot locked as resolved and limited conversation to collaborators May 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(eslint-plugin): add prefer-string-starts-ends-with rule (fixes #285) #289

feat(eslint-plugin): add prefer-string-starts-ends-with rule (fixes #285) #289

mysticatea commented Feb 16, 2019

codecov bot commented Feb 16, 2019 •

edited

Loading

mysticatea commented Feb 23, 2019

mysticatea commented Mar 6, 2019

bradzacher left a comment

JamesHenry left a comment

mysticatea commented Apr 9, 2019

teppeis commented Apr 25, 2019

fregante commented Mar 16, 2020

fregante commented Mar 16, 2020

feat(eslint-plugin): add prefer-string-starts-ends-with rule (fixes #285) #289

feat(eslint-plugin): add prefer-string-starts-ends-with rule (fixes #285) #289

Conversation

mysticatea commented Feb 16, 2019

codecov bot commented Feb 16, 2019 • edited Loading

Codecov Report

mysticatea commented Feb 23, 2019

mysticatea commented Mar 6, 2019

bradzacher left a comment

Choose a reason for hiding this comment

JamesHenry left a comment

Choose a reason for hiding this comment

mysticatea commented Apr 9, 2019

teppeis commented Apr 25, 2019

fregante commented Mar 16, 2020

fregante commented Mar 16, 2020

codecov bot commented Feb 16, 2019 •

edited

Loading