refactor: convert eslint-parser source and tests to TypeScript #29
Conversation
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
=========================================
- Coverage 94.16% 93.77% -0.4%
=========================================
Files 13 11 -2
Lines 1698 1686 -12
Branches 327 376 +49
=========================================
- Hits 1599 1581 -18
+ Misses 60 55 -5
- Partials 39 50 +11
Continue to review full report at Codecov.
|
|
Don't know what's up with codecov :/ |
|
It's working again :) |
…pescript-eslint into eslint-parser-to-ts
|
coverage went down because now we are collecting it, i don't see any issues with this you can set threshold in |
|
Thanks @armano2, I've added it to this PR so we don't forget about it |
| import { ParserOptions } from './parser-options'; | ||
| import { visitorKeys } from './visitor-keys'; | ||
|
|
||
| const packageJSON = require('../package.json'); |
There was a problem hiding this comment.
Just for my own understanding, why does require need to be used for JSON files? Is it just to avoid having to declare a JSON module interface, or is there something else at play here?
There was a problem hiding this comment.
"Is it just to avoid having to declare a JSON module interface", yes
There was a problem hiding this comment.
In this case, if you enabled resolveJsonModule in TS to allow you to import it, it will work, but because the package.json lives in the directory above the src it changes the output directory (dist) to contain nesting:
dist/
package.json
src/
Instead of the 1:1 mapping with src
No description provided.