-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(scope-manager): fix incorrect handling of class decorators and class method default params #2943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #2943 +/- ##
=======================================
Coverage 92.73% 92.74%
=======================================
Files 313 313
Lines 10632 10636 +4
Branches 3016 3017 +1
=======================================
+ Hits 9860 9864 +4
Misses 353 353
Partials 419 419
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@bradzacher We ran into this issue when installing latest today, which gave us v4.14.0. By any chance would you be able to create the v4.14.1 with this fix? |
https://github.com/typescript-eslint/typescript-eslint#package-versions This will be released on Monday. If you need it sooner, it's available on the |
You need to install the new version of the packages you're actually using - not a transient dependency. Our packages all intentionally have their dependencies pinned to a specific version to ensure the state is consistent. |
Fixes #2941
Fixes #2942
This was a regression introduced by #2751