test(ts-estree): add missing test cases #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armano2
commented
Feb 19, 2019
| @@ -2360,7 +2360,7 @@ export class Converter { | |||
| return this.fixExports(node, result); | |||
| } | |||
|
|
|||
| case SyntaxKind.FirstTypeNode: { | |||
| case SyntaxKind.TypePredicate: { | |||
There was a problem hiding this comment.
both SyntaxKind.FirstTypeNode and SyntaxKind.TypePredicate have same value (163),
but its better to use node kind instead of "counter"
armano2
commented
Feb 19, 2019
| @@ -452,6 +452,11 @@ tester.addFixturePatternConfig('typescript/errorRecovery', { | |||
| 'empty-type-parameters-in-function-expression', | |||
| 'empty-type-parameters-in-method', | |||
| 'empty-type-parameters-in-method-signature', | |||
| /** | |||
| * Babel correctly errors on this | |||
| * TODO: enable error code TS1024 | |||
There was a problem hiding this comment.
we should enable this error code in separate PR..
Codecov Report
@@ Coverage Diff @@
## master #300 +/- ##
==========================================
+ Coverage 96.76% 97.05% +0.29%
==========================================
Files 67 67
Lines 2350 2345 -5
Branches 335 334 -1
==========================================
+ Hits 2274 2276 +2
+ Misses 51 46 -5
+ Partials 25 23 -2
|
JamesHenry
approved these changes
Feb 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve coverage in ts-estree project