Codecov Report

Merging #305 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #305      +/-   ##
==========================================
+ Coverage    95.5%   95.52%   +0.02%     
==========================================
  Files          88       89       +1     
  Lines        4093     4112      +19     
  Branches     1150     1153       +3     
==========================================
+ Hits         3909     3928      +19     
  Misses         82       82              
  Partials      102      102

Hi @ldrick - #289 has been merged, so if you update this PR, we can merge it un

Hi @bradzacher , I am back from vacation and will change common used things. In the meanwhile, I have trouble with pulling master, due to 86 errors in linting. Did something change and how can this be fixed - because all of the linting issues refer not to this rule?

Try doing a yarn install followed by a build.

Try doing a yarn install followed by a build.

I tried locally, but linting fails, with exactly the same as azure pipelines in this PR. 😭
Might it be an issue with fresh install? I checked out everything on a new notebook and ran yarn; yarn build so it should install everything from yarn.lock. Thank you

Ahh, I see what's happening.
For some reason you committed your config all.json branch into this branch (b6d7590).

Which is why there are so many extra files.
It also looks like an old version of the branch, because there are changes to recommended.json (which are no longer present in #313).

You'll have to go through and remove the changes to fix up the changeset in this branch.
I just checked out your branch and tested; if you remove the recommended.json changes, there are no lint errors.

@bradzacher Wow, thank you many times, I literally screwed up my master and with it everything else. I'm going to round up this PR tomorrow and continue using only one notebook with my (kn)own configuration. 🙇

I did everything, I wanted to do. Please check, if moving getTypeName is what everyone would have expected and the way it should be. Thanks 👍

Hi, it would be nice to merge this one, to save me from merging masters 😸 and it was already approved. Thanks

@ldrick - We try to leave PRs open for around 2-3 weeks after getting an approval because we like to have 2 review approvals per feature PR.
We do 2-3 weeks because not all the core maintainers are available to spend a few hours every week.

Don't worry about checking back and merging master regularly. We'll coordinate that when it comes time to merge it.

That being said, it's probably time to merge this one in once these checks finish!