-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(typescript-estree): correct test names on windows for semantic-diagnostics-enabled #3060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR, @armano2! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
@bradzacher do you have an idea why |
nope - it's a pretty shitty service TBH - it seemingly only works like 30% of the time. |
hmm, it seem that this error is already reported and there seem to be workaround for this. https://docs.codecov.io/docs/codecovyml-reference#codecovrequire_ci_to_pass i will submit, pr and try disabling this option |
This issue with tests is present only on windows and was introduced in #3045
https://github.com/typescript-eslint/typescript-eslint/pull/3045/files#r575688728
integration tests are failing due to #3045