Skip to content

test(eslint-plugin): [no-unsafe-assignment] add missing test cases #3070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2021
Merged

test(eslint-plugin): [no-unsafe-assignment] add missing test cases #3070

merged 1 commit into from
Feb 18, 2021

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Feb 18, 2021

No description provided.

@armano2 armano2 added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin tests anything to do with testing labels Feb 18, 2021
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #3070 (aff998b) into master (022fddf) will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3070      +/-   ##
==========================================
+ Coverage   92.69%   92.83%   +0.14%     
==========================================
  Files         314      314              
  Lines       10675    10675              
  Branches     3027     3027              
==========================================
+ Hits         9895     9910      +15     
+ Misses        358      348      -10     
+ Partials      422      417       -5
Flag Coverage Δ
unittest 92.83% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/eslint-plugin/src/rules/no-unsafe-assignment.ts 93.22% <0.00%> (+12.71%) ⬆️

@armano2 armano2 merged commit e9bdd07 into master Feb 18, 2021
@armano2 armano2 deleted the test/no-usafe-assignment branch February 18, 2021 18:40
@armano2 armano2 changed the title test(eslint-plugin): [no-unsafe-assignment] add test cases for uncovered code test(eslint-plugin): [no-unsafe-assignment] add missing test cases Feb 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin tests anything to do with testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armano2 @bradzacher