Skip to content

chore: update codecov configuration #3072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2021
Merged

chore: update codecov configuration #3072

merged 2 commits into from
Feb 19, 2021

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Feb 18, 2021

Update codecov to not wait for all ci to report its status, this should fix issue with

Expected — Waiting for status to be reported

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

bradzacher
bradzacher previously approved these changes Feb 18, 2021
Comment on lines +63 to +64
with:
fetch-depth: 2
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is needed for codecov to be able to detect correct commit SHA

==> GitHub Actions detected.
-> Issue detecting commit SHA. Please run actions/checkout with fetch-depth > 1 or set to 0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you set it to 0?

Copy link
Collaborator Author

@armano2 armano2 Feb 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could but its better not to, fetching only 1 (in this case 2) commit is huge boost to time of git fetch/clone

this property is used to tell git how many commit we want to fetch

@armano2 armano2 added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Feb 19, 2021
@armano2 armano2 merged commit 1bd8f4e into master Feb 19, 2021
@armano2 armano2 deleted the chore/codecov branch February 19, 2021 01:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants