Skip to content

feat: create TSTypeQuery node when TSImportType has isTypeOf #3076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 26, 2022
Merged

feat: create TSTypeQuery node when TSImportType has isTypeOf #3076

merged 6 commits into from
Oct 26, 2022

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Feb 19, 2021 •
edited by bradzacher
Loading

BREAKING CHANGE:
Changes AST structure in a backwards-incompatible way

fixes #2998

@armano2 armano2 added breaking change This change will require a new major version to be released AST PRs and Issues about the AST structure labels Feb 19, 2021
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@armano2 armano2 changed the title feat: update TSImportType node feat: create TSTypeQuery node when TSImportType has isTypeOf Feb 19, 2021
armano2
armano2 commented Feb 19, 2021
View reviewed changes
packages/typescript-estree/src/convert.ts
parameter: this.convertChild(node.argument),
argument: this.convertChild(node.argument),
Copy link
Collaborator Author

@armano2 armano2 Feb 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i renamed this property from parameter to argument as is more aligned with typescript/babel and rest of types

eg, call expression has arguments

@armano2 armano2 mentioned this pull request Feb 19, 2021
Closed
1 task
@codecov
Copy link

codecov bot commented Feb 19, 2021 •
edited
Loading

Codecov Report

Merging #3076 (059d912) into master (5e2a993) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3076   +/-   ##
=======================================
  Coverage   92.87%   92.88%           
=======================================
  Files         314      314           
  Lines       10670    10679    +9     
  Branches     3026     3029    +3     
=======================================
+ Hits         9910     9919    +9     
  Misses        344      344           
  Partials      416      416
Flag Coverage Δ
unittest 92.88% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pt-estree/src/ts-estree/estree-to-ts-node-types.ts 100.00% <ø> (ø)
packages/visitor-keys/src/visitor-keys.ts 100.00% <ø> (ø)
...ckages/scope-manager/src/referencer/TypeVisitor.ts 94.79% <100.00%> (+0.11%) ⬆️
packages/typescript-estree/src/convert.ts 98.38% <100.00%> (+0.01%) ⬆️

@armano2 armano2 added package: scope-manager Issues related to @typescript-eslint/scope-manager package: typescript-estree Issues related to @typescript-eslint/typescript-estree and removed package: scope-manager Issues related to @typescript-eslint/scope-manager package: typescript-estree Issues related to @typescript-eslint/typescript-estree labels Feb 19, 2021
@armano2 armano2 marked this pull request as ready for review February 19, 2021 19:51
@armano2 armano2 added this to the 5.0.0 milestone Feb 20, 2021
@armano2 armano2 mentioned this pull request Feb 23, 2021
Merged
@armano2 armano2 force-pushed the feat/ts-import-type branch from a4e7a59 to 059d912 Compare February 24, 2021 22:14
@bradzacher bradzacher changed the base branch from master to v5 August 21, 2021 22:16
@bradzacher bradzacher force-pushed the v5 branch 2 times, most recently from ae8ad40 to cbbf22a Compare September 21, 2021 01:08
@bradzacher bradzacher modified the milestones: 5.0.0, 6.0.0 Oct 11, 2021
Base automatically changed from v5 to master October 11, 2021 17:55
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Jan 23, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I'm not high enough confidence in AST dealings to merge myself, so I'll defer to @bradzacher

@bradzacher
Copy link
Member

yeah this is sound - just needs to wait for the next major

@bradzacher bradzacher added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jan 24, 2022
@bradzacher bradzacher mentioned this pull request Apr 17, 2022
Merged
JoshuaKGoldberg and others added 4 commits October 25, 2022 15:22
@JoshuaKGoldberg
chore: document and refactor 'extra' to 'parserSettings' (#5834)
8ddcc9a
@JoshuaKGoldberg
chore(website): fix renamed Sponsorship docs link (#5882)
8794fd3
@adnanhashmi09 @JoshuaKGoldberg
docs: Mention wide globs performance implications in monorepos docs a…
fcf3f9d 
…nd parser README (#5864)

* docs: Mention wide globs performance implications in monorepos docs and parser readme

* Update docs/linting/typed-linting/MONOREPOS.md

Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
@JoshuaKGoldberg
Merge branch 'main'
0e6bced
@JoshuaKGoldberg JoshuaKGoldberg dismissed stale reviews from ghost and themself via 0e6bced October 26, 2022 00:27
@nx-cloud
Copy link

nx-cloud bot commented Oct 26, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0e6bced. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Oct 26, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 0e6bced
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63587f1121070f000963d707
😎 Deploy Preview https://deploy-preview-3076--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg changed the base branch from main to v6 October 26, 2022 00:40
@JoshuaKGoldberg JoshuaKGoldberg merged commit 04488c2 into v6 Oct 26, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the feat/ts-import-type branch October 26, 2022 00:42
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Nov 12, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge AST PRs and Issues about the AST structure breaking change This change will require a new major version to be released
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

[RFC] AST structure of TSImportType to be more align with rest of AST
4 participants
@armano2 @bradzacher @JoshuaKGoldberg @adnanhashmi09