fix(typescript-estree): correct issues in AST definition #3083

armano2 · 2021-02-21T14:59:07Z

Those changes has been extracted from #3078

`ProgramStatement` and `Statement` nodes can contain same set of nodes

if (x) export {x}
if (x) import test from 'x'
// -----
for (x in foo) {
  export {x}
}
// -----
function test (x: string) {
  export {x}
}

`LeftHandSideExpression` can be a `AwaitExpression`

const a = ++(await x)

`TryStatement` finalizer can be `null`

try {} catch {}

`RegExpLiteral` value can be `null` if regexp is invalid or unsupported by env

good example in this case can be any proposal that has not been accepted yet
eg. https://github.com/tc39/proposal-regexp-match-indices

const x = /a+(?<Z>z)?/d

`JSXOpeningElement` attributes can be a `JSXSpreadAttribute`

const foo = <x {...spread}></x>

`TSModuleDeclaration` body can be `TSModuleDeclaration`

// TSModuleDeclaration without body
module "x";
// TSModuleDeclaration -> TSModuleBlock
module x {
}
// TSModuleDeclaration -> TSModuleDeclaration **
module x.x {
}

typescript-eslint · 2021-02-21T14:59:11Z

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

codecov · 2021-02-21T15:16:22Z

Codecov Report

Merging #3083 (ac64fe0) into master (409bf0b) will increase coverage by 0.00%.
The diff coverage is 90.90%.

@@           Coverage Diff           @@
##           master    #3083   +/-   ##
=======================================
  Coverage   92.83%   92.83%           
=======================================
  Files         314      314           
  Lines       10671    10672    +1     
  Branches     3027     3027           
=======================================
+ Hits         9906     9907    +1     
  Misses        348      348           
  Partials      417      417

Flag	Coverage Δ
unittest	`92.83% <90.90%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/eslint-plugin/src/rules/no-unused-vars.ts	`96.68% <80.00%> (+0.02%)`	⬆️
packages/typescript-estree/src/convert.ts	`98.36% <100.00%> (ø)`

packages/eslint-plugin/src/rules/no-unused-vars.ts

packages/types/src/ts-estree.ts

bradzacher · 2021-02-21T23:37:21Z

packages/types/src/ts-estree.ts

 }

 export interface TSModuleDeclaration extends BaseNode {
  type: AST_NODE_TYPES.TSModuleDeclaration;
  id: Identifier | Literal;
-  body?: TSModuleBlock;
+  body?: TSModuleBlock | TSModuleDeclaration;


we really need to fix this - #2573

fix: correct issues in AST definition

fe74a6f

armano2 added AST PRs and Issues about the AST structure bug Something isn't working labels Feb 21, 2021

fix: add missing type check to no-unused-vars

34b9d6a

armano2 force-pushed the fix/ast-structure branch from 1121cd7 to 34b9d6a Compare February 21, 2021 15:05

armano2 requested a review from bradzacher February 21, 2021 15:17

armano2 commented Feb 21, 2021

View reviewed changes

packages/eslint-plugin/src/rules/no-unused-vars.ts Outdated Show resolved Hide resolved

fix: improve type-check in no-unused-vars

cd42cf9

bradzacher reviewed Feb 21, 2021

View reviewed changes

packages/types/src/ts-estree.ts Outdated Show resolved Hide resolved

armano2 added 2 commits February 21, 2021 19:56

chore: update comment about ProgramStatement

ccd18e1

chore: remove @deprecated from ProgramStatement

5177137

armano2 mentioned this pull request Feb 21, 2021

refactor(typescript-estree): add type guards for typescript-estree #3078

Closed

bradzacher approved these changes Feb 21, 2021

View reviewed changes

armano2 changed the title ~~fix: correct issues in AST definition~~ fix(typescript-estree): correct issues in AST definition Feb 21, 2021

Merge branch 'master' into fix/ast-structure

ac64fe0

armano2 merged commit 509a117 into master Feb 22, 2021

armano2 deleted the fix/ast-structure branch February 22, 2021 01:18

github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(typescript-estree): correct issues in AST definition #3083

fix(typescript-estree): correct issues in AST definition #3083

armano2 commented Feb 21, 2021 •

edited

Loading

typescript-eslint bot commented Feb 21, 2021

codecov bot commented Feb 21, 2021 •

edited

Loading

bradzacher Feb 21, 2021

fix(typescript-estree): correct issues in AST definition #3083

fix(typescript-estree): correct issues in AST definition #3083

Conversation

armano2 commented Feb 21, 2021 • edited Loading

ProgramStatement and Statement nodes can contain same set of nodes

LeftHandSideExpression can be a AwaitExpression

TryStatement finalizer can be null

RegExpLiteral value can be null if regexp is invalid or unsupported by env

JSXOpeningElement attributes can be a JSXSpreadAttribute

TSModuleDeclaration body can be TSModuleDeclaration

typescript-eslint bot commented Feb 21, 2021

codecov bot commented Feb 21, 2021 • edited Loading

Codecov Report

bradzacher Feb 21, 2021

Choose a reason for hiding this comment

armano2 commented Feb 21, 2021 •

edited

Loading

`ProgramStatement` and `Statement` nodes can contain same set of nodes

`LeftHandSideExpression` can be a `AwaitExpression`

`TryStatement` finalizer can be `null`

`RegExpLiteral` value can be `null` if regexp is invalid or unsupported by env

`JSXOpeningElement` attributes can be a `JSXSpreadAttribute`

`TSModuleDeclaration` body can be `TSModuleDeclaration`

codecov bot commented Feb 21, 2021 •

edited

Loading