Skip to content

feat(typescript-estree): remove legacy useJSXTextNode option #3109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 22, 2021
Merged

feat(typescript-estree): remove legacy useJSXTextNode option #3109

merged 6 commits into from
Aug 22, 2021

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Feb 24, 2021 •
edited
Loading

This change removes legacy option for useJSXTag names and enable it always.
This option was present to support use case of eslint 5

This change is related to #2683

https://astexplorer.net/#/gist/80c278121e6b7a6984ef08d730040240/7d48b11779b51084a3457ae301011e1a69ae50ef
https://github.com/facebook/jsx

@armano2 armano2 added package: typescript-estree Issues related to @typescript-eslint/typescript-estree breaking change This change will require a new major version to be released labels Feb 24, 2021
@armano2 armano2 added this to the 5.0.0 milestone Feb 24, 2021
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@armano2 armano2 changed the title feat(typescript-estree): remove legacy useJSXTextNode option feat(typescript-estree): remove legacy useJSXTextNode option used by eslint 5 Feb 24, 2021
@bradzacher bradzacher changed the base branch from master to v5 August 21, 2021 22:16
@bradzacher
Merge branch 'v5' into feat/drop-jsx-tag-node
b4a197e 
# Conflicts:
#	packages/typescript-estree/src/convert.ts
#	packages/typescript-estree/src/parser-options.ts
#	packages/typescript-estree/src/parser.ts
@nx-cloud
Copy link

nx-cloud bot commented Aug 22, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit ac4f6bd. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/eslint-plugin-internal
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/eslint-plugin-tslint
#000000 nx test @typescript-eslint/eslint-plugin
#000000 nx test @typescript-eslint/parser
#000000 nx test @typescript-eslint/experimental-utils
#000000 nx test @typescript-eslint/scope-manager
#000000 nx test @typescript-eslint/visitor-keys
#000000 nx test @typescript-eslint/typescript-estree
#000000 nx run-many --target=build --all --parallel
#000000 nx test @typescript-eslint/parser
#000000 nx test @typescript-eslint/experimental-utils
#000000 nx test @typescript-eslint/scope-manager
#000000 nx test @typescript-eslint/visitor-keys
#000000 nx test @typescript-eslint/typescript-estree

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Aug 22, 2021 •
edited
Loading

Codecov Report

Merging #3109 (ac4f6bd) into v5 (48858c9) will decrease coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##               v5    #3109      +/-   ##
==========================================
- Coverage   93.42%   93.22%   -0.20%     
==========================================
  Files         147      154       +7     
  Lines        7804     8063     +259     
  Branches     2472     2538      +66     
==========================================
+ Hits         7291     7517     +226     
- Misses        176      188      +12     
- Partials      337      358      +21
Flag Coverage Δ
unittest 93.22% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gin-internal/src/rules/no-poorly-typed-ts-props.ts 88.88% <0.00%> (ø)
packages/eslint-plugin-tslint/src/rules/config.ts 97.36% <0.00%> (ø)
packages/eslint-plugin-tslint/src/custom-linter.ts 100.00% <0.00%> (ø)
...plugin-internal/src/rules/prefer-ast-types-enum.ts 90.00% <0.00%> (ø)
...internal/src/rules/no-typescript-default-import.ts 100.00% <0.00%> (ø)
...lugin-internal/src/rules/plugin-test-formatting.ts 81.75% <0.00%> (ø)
...-internal/src/rules/no-typescript-estree-import.ts 87.50% <0.00%> (ø)

@bradzacher bradzacher changed the title feat(typescript-estree): remove legacy useJSXTextNode option used by eslint 5 feat(typescript-estree): remove legacy useJSXTextNode option Aug 22, 2021
@bradzacher bradzacher merged commit e80056f into v5 Aug 22, 2021
@bradzacher bradzacher deleted the feat/drop-jsx-tag-node branch August 22, 2021 02:22
bradzacher pushed a commit that referenced this pull request Sep 3, 2021
@armano2 @bradzacher
feat(typescript-estree): remove legacy useJSXTextNode option (#3109)
b11d68b
bradzacher pushed a commit that referenced this pull request Sep 21, 2021
@armano2 @bradzacher
feat(typescript-estree): remove legacy useJSXTextNode option (#3109)
2ee41b9
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
breaking change This change will require a new major version to be released package: typescript-estree Issues related to @typescript-eslint/typescript-estree
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@armano2 @bradzacher