-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(eslint-plugin): add config all.json #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): add config all.json #313
Conversation
Resolved 😅 |
Codecov Report
@@ Coverage Diff @@
## master #313 +/- ##
==========================================
+ Coverage 95.52% 95.82% +0.29%
==========================================
Files 89 90 +1
Lines 4112 4164 +52
Branches 1153 1153
==========================================
+ Hits 3928 3990 +62
+ Misses 82 72 -10
Partials 102 102
|
A few things:
would suggest specifically adding a new property to interface RuleMetaDataDocs {
// ....
/**
* Set to true if the rule overrides (i.e. replaces) the base eslint rule of the same name. This will cause the associated base rule to be disabled when generating the shared configs.
*/
overridesBaseRule?: true
}
|
Hi @bradzacher , thanks for reviewing.
I tried to shortly explain on @armano2 's review, but I see it collapsed due to resolving the request.
I'll wait for an answer here and sure I'm willing to change it.
Sure, I'll do that, so every config comes from generate-configs.ts |
@ldrick Hi ! I'd love to use this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM.
one required change with the base config. few nitpicks.
Great work.
What is missing to use the all config ? There is nothing in the doc: https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/src/configs/README.md |
We just never added documentation. |
Fixes: #298
Fixes: #353
This PR fixes possibility to run recreation of shared configs with ts-node and adds all.json as new shared config.