feat(eslint-plugin): add strict-comparisons rule #314
Conversation
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
=========================================
- Coverage 97.2% 97.11% -0.1%
=========================================
Files 68 69 +1
Lines 2505 2562 +57
Branches 387 393 +6
=========================================
+ Hits 2435 2488 +53
- Misses 44 46 +2
- Partials 26 28 +2
|
|
So I think from my side this would be ready. Is there anything else I should do? @bradzacher @mohsen1 The corresponding tslint PR is still pending due to some compatibility issues with TS 2.1 and some new linting errors in their codebase. |
There was a problem hiding this comment.
a few nits, otherwise LGTM.
It would be good to see some examples/docs clarifying what cases are valid with some more types.
i.e. it's not obvious from the docs (or tests) whether I can do this without the allowObjectEqualComparison option, because your examples mostly use literals:
const x : T | null = ...;
if (x === null) { .... }|
@bradzacher thanks. I'll update the docs and examples to clarify the different cases, once that is done I think it's ready from my side. |
|
Hi @AndreasGassmann, thanks again for the PR, when do you think you will have chance to finalise this one? |
|
Sorry for not working on this for so long. I'll look at it this week. |
Adds a
strict-comparisonsrule.I also made a PR on the TSLint repo palantir/tslint#4519 which addresses an open issue palantir/tslint#3574. Once that one gets merged, I'll update the references in this PR.
I'm not sure about the name, I started calling it
no-object-comparisons, but now it feels like it's doing more than just that, sostrict-comparisonsseems more fitting.I'll have to migrate over some more tests from the TSLint repo, but because of the different format this takes quite some time.