refactor(eslint-plugin): use direct ts type guards instead of tsutils #3193

armano2 · 2021-03-16T22:01:44Z

No description provided.

typescript-eslint · 2021-03-16T22:01:48Z

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

codecov · 2021-03-16T22:13:54Z

Codecov Report

Merging #3193 (6f1e226) into master (7b6f2ab) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3193   +/-   ##
=======================================
  Coverage   92.91%   92.91%           
=======================================
  Files         316      316           
  Lines       10808    10808           
  Branches     3056     3056           
=======================================
  Hits        10042    10042           
  Misses        342      342           
  Partials      424      424

Flag	Coverage Δ
unittest	`92.91% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...es/eslint-plugin/src/rules/no-floating-promises.ts	`100.00% <100.00%> (ø)`
...-plugin/src/rules/no-unnecessary-type-arguments.ts	`97.87% <100.00%> (ø)`
packages/eslint-plugin/src/rules/return-await.ts	`95.87% <100.00%> (ø)`

bradzacher

maybe we should add an internal lint rule for this?
check all tsutil member expressions and if the property is exported by TS, then report?

refactor(eslint-plugin): use direct ts type guards instead of tsutils

6f1e226

armano2 added the package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin label Mar 16, 2021

bradzacher approved these changes Mar 17, 2021

View reviewed changes

armano2 merged commit 9ed3c50 into master Mar 17, 2021

armano2 deleted the refactor/tsutils branch March 17, 2021 10:25

github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(eslint-plugin): use direct ts type guards instead of tsutils #3193

refactor(eslint-plugin): use direct ts type guards instead of tsutils #3193

armano2 commented Mar 16, 2021

typescript-eslint bot commented Mar 16, 2021

codecov bot commented Mar 16, 2021

bradzacher left a comment

refactor(eslint-plugin): use direct ts type guards instead of tsutils #3193

refactor(eslint-plugin): use direct ts type guards instead of tsutils #3193

Conversation

armano2 commented Mar 16, 2021

typescript-eslint bot commented Mar 16, 2021

codecov bot commented Mar 16, 2021

Codecov Report

bradzacher left a comment

Choose a reason for hiding this comment