Skip to content

feat(eslint-plugin): [unbound-method] improve error message #3203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2021
Merged

feat(eslint-plugin): [unbound-method] improve error message #3203

merged 3 commits into from
Mar 21, 2021

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Mar 19, 2021

close #3201

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JounQin!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Mar 20, 2021
bradzacher
bradzacher requested changes Mar 20, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! a few comments

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Mar 20, 2021
JounQin and others added 2 commits March 20, 2021 08:59
@JounQin @bradzacher
Update packages/eslint-plugin/docs/rules/unbound-method.md
2a6026f 
Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
@JounQin
feat: check if the first param is this
f55107c 
add new message `unboundWithoutThisAnnotation`
@JounQin JounQin requested a review from bradzacher March 20, 2021 01:52
@codecov
Copy link

codecov bot commented Mar 20, 2021 •
edited
Loading

Codecov Report

Merging #3203 (f55107c) into master (e3a3ea0) will decrease coverage by 0.01%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #3203      +/-   ##
==========================================
- Coverage   92.91%   92.90%   -0.02%     
==========================================
  Files         316      316              
  Lines       10818    10822       +4     
  Branches     3059     3061       +2     
==========================================
+ Hits        10052    10054       +2     
- Misses        342      343       +1     
- Partials      424      425       +1
Flag Coverage Δ
unittest 92.90% <83.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/unbound-method.ts 91.30% <83.33%> (-1.88%) ⬇️

@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Mar 20, 2021
bradzacher
bradzacher approved these changes Mar 21, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for adding this!

@bradzacher bradzacher added enhancement New feature or request and removed documentation Documentation ("docs") that needs adding/updating labels Mar 21, 2021
@bradzacher bradzacher changed the title docs: highlight this: void and arrow function for unbound-method feat(eslint-plugin): [unbound-method] improve error message Mar 21, 2021
@bradzacher bradzacher merged commit 5cc5d2e into typescript-eslint:master Mar 21, 2021
@JounQin JounQin deleted the docs/this_void branch March 21, 2021 23:23
@Obi-Dann Obi-Dann mentioned this pull request Apr 10, 2021
Draft
@github-actions github-actions bot mentioned this pull request Apr 12, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[unbound-method] this: void syntax should be highlighted in document and suggested in message
2 participants
@JounQin @bradzacher