Skip to content

chore: enable no-unsafe-call locally #3281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 19, 2021
Merged

chore: enable no-unsafe-call locally #3281

merged 5 commits into from
Apr 19, 2021

Conversation

JoshuaKGoldberg
Copy link
Member

Continues #3278.

isomorphic-fetch's types rely on a global fetch to already exist. node-fetch is already a dev dependency so I switched the generate-contributors calls to it.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Apr 11, 2021
Merged
@codecov
Copy link

codecov bot commented Apr 11, 2021 •
edited
Loading

Codecov Report

Merging #3281 (8bbd685) into master (26d71b5) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3281      +/-   ##
==========================================
- Coverage   92.86%   92.86%   -0.01%     
==========================================
  Files         318      318              
  Lines       11049    11048       -1     
  Branches     3129     3129              
==========================================
- Hits        10261    10260       -1     
  Misses        350      350              
  Partials      438      438
Flag Coverage Δ
unittest 92.86% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../experimental-utils/src/eslint-utils/RuleTester.ts 9.30% <ø> (ø)
packages/typescript-estree/src/convert.ts 98.24% <ø> (ø)
packages/eslint-plugin-tslint/src/custom-linter.ts 100.00% <100.00%> (ø)

bradzacher
bradzacher previously approved these changes Apr 12, 2021
View reviewed changes
@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Apr 19, 2021
@bradzacher
Copy link
Member

Thanks! 🥇

@bradzacher bradzacher changed the title chore: enable no-unsafe-call locally chore: enable no-unsafe-call locally Apr 19, 2021
@bradzacher bradzacher merged commit b4cf0da into typescript-eslint:master Apr 19, 2021
@JoshuaKGoldberg JoshuaKGoldberg deleted the no-unsafe-call branch April 19, 2021 17:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaKGoldberg @bradzacher