Skip to content

refactor(eslint-parser): add definition for eslint-scope #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 17, 2019
Merged

refactor(eslint-parser): add definition for eslint-scope #33

merged 4 commits into from
Jan 17, 2019

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Jan 16, 2019 •
edited
Loading

Not all of types are resolved a lot of properties has type any

@types/estree should be replaced with definition from typescript-estree, but i didn't finish it yet there

@codecov
Copy link

codecov bot commented Jan 17, 2019 •
edited
Loading

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   93.77%   93.77%           
=======================================
  Files          11       11           
  Lines        1686     1686           
  Branches      376      376           
=======================================
  Hits         1581     1581           
  Misses         55       55           
  Partials       50       50
Impacted Files Coverage Δ
...ages/typescript-eslint-parser/src/analyze-scope.ts 93.25% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dcb159...518f439. Read the comment docs.

JamesHenry
JamesHenry previously approved these changes Jan 17, 2019
View reviewed changes
@armano2
Copy link
Collaborator Author

armano2 commented Jan 17, 2019

i'm still working on this :>

@armano2
Copy link
Collaborator Author

armano2 commented Jan 17, 2019 •
edited
Loading

ok its finished

@JamesHenry JamesHenry merged commit ebe638b into typescript-eslint:master Jan 17, 2019
@armano2 armano2 deleted the eslint-scope branch January 17, 2019 01:09
JamesHenry pushed a commit that referenced this pull request Jan 17, 2019
@armano2 @JamesHenry
Migrate typescript-eslint-parser to 21.0.2 (#174)
afe62b4 
fixes: #152, #155, #126, #164, #166, #171, #193, #189, #143, #33
JamesHenry pushed a commit that referenced this pull request Jan 17, 2019
@armano2 @JamesHenry
Migrate typescript-eslint-parser to 21.0.2 (#174)
1fe200f 
fixes: #152, #155, #126, #164, #166, #171, #193, #189, #143, #33
JamesHenry pushed a commit that referenced this pull request Jan 18, 2019
@armano2 @JamesHenry
Migrate typescript-eslint-parser to 21.0.2 (#174)
a58846c 
fixes: #152, #155, #126, #164, #166, #171, #193, #189, #143, #33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armano2 @JamesHenry